Rework event provider and other changes #21

leming · 2026-06-28T18:34:28Z

leming commented

2026-06-28 18:34:28 +00:00

This PR contains multiple changes.
Regarding event provider rework:

Place existing implementation in a class based on abstract class. This is to make it at least somewhat testable.
Return structured Event data from EventProvider.
Improved workflow, along with comments.

Changes unrelated to that, with no significant order:

Rename f to file.
Add logging support.
Replace os/str paths with pathlib.
Fix wrong timezone.
Add a load of TODOs.

This PR contains multiple changes. Regarding event provider rework: - Place existing implementation in a class based on abstract class. This is to make it at least somewhat testable. - Return structured `Event` data from `EventProvider`. - Improved workflow, along with comments. Changes unrelated to that, with no significant order: - Rename `f` to `file`. - Add `logging` support. - Replace `os`/`str` paths with `pathlib`. - Fix wrong timezone. - Add a load of TODOs.

leming added 2 commits

2026-06-28 18:34:29 +00:00

Rework event provider 2d426a189c

Additional reworks 3dbca9d1ef

- Use logging where possible.
- Use pathlib instead of os and strings.
- Fail quickly on no DISCORD_TOKEN.
- Fix some issues from previous commit.

leming requested reviews from doomhammer, konrad.skiba

2026-06-28 18:34:36 +00:00

doomhammer reviewed

2026-06-28 19:18:32 +00:00

src/kronos/discordbot.py

					
				@ -5,36 +5,39 @@ Discord connector to export events to one or more Discord communities (aka guild

				"""

If we treat mobilizon as event_provider, shouldn't this be event_consumer?

Yes, yes it should. To be solved in some future PR.

leming marked this conversation as resolved

doomhammer reviewed

2026-06-28 19:19:33 +00:00

src/kronos/main.py Outdated

					
				@ -134,3 +141,3 @@

				  template = env.get_template(template_name)

				  now_paris = datetime.datetime.now(ZoneInfo("Europe/Paris")).strftime("%Y-%m-%d %H:%M")

				  now_paris = datetime.now(ZoneInfo("Europe/Paris")).strftime("%Y-%m-%d %H:%M")

I think we can move to Warsaw now.

leming marked this conversation as resolved

doomhammer reviewed

2026-06-28 19:19:51 +00:00

src/kronos/main.py

					
				@ -32,3 +35,4 @@

				TEMPLATES = {

				  "templates/newsletter_template.html": "newsletter_events.html",

				}

				CREATOR_URL = "https://events.hs3.pl"

Second time? There's already one in kronos-ui

I intend to merge kronos and kronos-ui in the long run, right now TODO must do.

I intend to merge `kronos` and `kronos-ui` in the long run, right now TODO must do.

leming marked this conversation as resolved

doomhammer commented

2026-06-28 19:21:42 +00:00

Cool, but a short description could help understand why are we here :)

doomhammer approved these changes

2026-06-28 19:22:01 +00:00

Dismissed

leming added 1 commit

2026-06-28 20:09:03 +00:00

Structured Event data, improved text description usage 02f27e1de2

leming requested review from doomhammer

2026-06-28 20:16:57 +00:00

leming added 1 commit

2026-06-29 19:39:41 +00:00

Restore truncate to main f916e65ba8

doomhammer reviewed

2026-06-29 20:26:48 +00:00

src/kronos/event_provider.py Outdated

					
				@ -0,0 +375,4 @@

				if __name__ == "__main__":

				  logging.basicConfig(format="%(asctime)s %(levelname)s: %(message)s", level=logging.INFO)

				  # TODO: executable part of this script is only for development purposes. Replace with tests.

💚

doomhammer reviewed

2026-06-29 20:27:17 +00:00

src/kronos/event_provider.py

					
				@ -0,0 +247,4 @@

				      List of events.

				    """

				    # TODO: this function seem weird - move responsiblity elsewhere?

				    # Or add explicit method for Typst to get data?

👍

doomhammer reviewed

2026-06-29 20:28:24 +00:00

src/kronos-ui/main.py Outdated

					
				@ -73,3 +89,3 @@

				      "description": description,

				      "physicalAddress": None,

				      "picture": os.path.relpath(pic_path, start="src/typst"),

				      "picture": pic_path.relative_to("src/path"),