Rework Discord event consumer #22
No reviewers
Labels
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
leming/kronos!22
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "arkjedrz_rework-discord-consumer"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Eventto separate module.@ -0,0 +18,4 @@__all__ = ["DiscordEventConsumer"]def _event_time(time_iso_format: str) -> datetime:Shouldn't this be part of
event? Hardly seems Discord-relatedAgree, will probably do along with next consumer change.
#23
@ -0,0 +60,4 @@with open(event_mapping_path, "rb") as file:event_mapping = pickle.load(file)except Exception:# TODO: shouldn't this stop the execution?First run never has a pickle jar so stopping it wouldn't be a good idea
@ -0,0 +74,4 @@# Set description.description = f"{event.url}\n\n{event.text_description}"# Download image.I think this could also be the provider's job, not the consumer's
Agree, to be done separately.
#25
@ -0,0 +17,4 @@"""@abstractmethoddef consume(self, events: list[Event]) -> None:nomnomnom
@ -151,3 +154,3 @@try:# Load `DISCORD_TOKEN` from environment variable.# # Load `DISCORD_TOKEN` from environment variable.eh?
5a1ce519bato7a0b7beb22WIP: Rework Discord event consumerto Rework Discord event consumer